mongodb / mongo-php-driver

The Official MongoDB PHP driver
https://pecl.php.net/package/mongodb
Apache License 2.0
878 stars 199 forks source link

PHPC-2375: Manually merge up version bump commits #1586

Closed alcaeus closed 1 month ago

alcaeus commented 1 month ago

PHPC-2375

This PR adds logic to automatically merge up changes to the next release branch. This is necessary as the pull request for the merge-up action will always have a conflict due to the version already having changed in the next branch.

If the branch detection logic finds a newer branch to merge to (which it always should as we're releasing from version branches), it runs a git merge --strategy=ours in this next branch, then pushes those changes before pushing the release branch. By pushing the next branch before the release branch, the merge-up action discovers that there are no commits to be merged from the release branch into the next branch and will not create a merge-up pull request.

Note that if the release branch contains changes that have not been merged up yet, those changes will be marked as merged without applying them. I can add logic to detect this and prevent a release, but this case shouldn't come up very often as we're quite diligent about merging the merge-up pull requests so I've decided against it for the time being.