mongodb / mongodb-atlas-kubernetes

MongoDB Atlas Kubernetes Operator - Manage your MongoDB Atlas clusters from Kubernetes
http://www.mongodb.com/cloud/atlas
Apache License 2.0
152 stars 78 forks source link

CLOUDP-280225: Refactor integration secret checks #1902

Closed josvazg closed 3 days ago

josvazg commented 1 week ago

Atlas redacts integrations secrets for security reasons, which means we cannot:

This change preserves that behaviour without assuming any extension to this behaviour coming any time soon. A proper fix will have to come from Atlas, for instance, sending a hash of the secret that allows comparison by applying the same on the client side.

All Submissions:

github-actions[bot] commented 1 week ago

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/048afd4b3d2defb6b032a07de5da2953c3af8e45

josvazg commented 1 week ago

Will hold until @s-urbaniak can review this one

josvazg commented 1 week ago

Alternatively we could just remove the secret values from comparisons, so we only take into account Kubernetes changes, and ignore changes from Atlas.