Cloudp 261730 alert configuration missing matchers - Githubissues

mongodb / mongodbatlas-cloudformation-resources

MongoDB Atlas CloudFormation Resources: Deploy, update, and manage MongoDB Atlas infrastructure as code through AWS CloudFormation

https://www.mongodb.com/atlas/aws-cloudformation

Apache License 2.0

58 stars 38 forks source link

Cloudp 261730 alert configuration missing matchers #1098

Closed marcosuma closed 2 months ago

marcosuma commented 2 months ago

Proposed changes

Based on https://github.com/mongodb/awscdk-resources-mongodbatlas/pull/319, we need to update the list of matchers

ALTERNATIVE OPTION

Looking in TF, should we actually remove this enum and just leave it open as string?

Jira ticket: CLOUDP-261730

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

[ ] cfn invoke for each of CRUDL/cfn test
[ ] Updated resource in example
[ ] Published to AWS private registry
[ ] Used the template in example to create and update a stack in AWS
[ ] Deleted stack to ensure resources are deleted
[ ] Created multiple resources in same stack
[ ] Validated in Atlas UI
[ ] Included screenshots

Required Checklist:

[x] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code
[x] For CFN Resources: I have released by changes in the private registry and proved by change works in Atlas

Further comments

github-actions[bot] commented 2 months ago

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details: CONTRIBUTING.md

No release type found in pull request title "Cloudp 261730 alert configuration missing matchers". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - chore
 - doc
 - test
 - security
 - remove
 - deprecate
 - refactor
 - perf
 - ci
 - revert
 - style