mongodb / mongodbatlas-cloudformation-resources

MongoDB Atlas CloudFormation Resources: Deploy, update, and manage MongoDB Atlas infrastructure as code through AWS CloudFormation
https://www.mongodb.com/atlas/aws-cloudformation
Apache License 2.0
58 stars 38 forks source link

chore: Renames `AwsKms` to `AwsKmsConfig` in `encryption-at-rest` #1112

Closed lantoli closed 1 month ago

lantoli commented 1 month ago

Proposed changes

Renames AwsKms to AwsKmsConfig in encryption-at-rest to avoid errors in CDK:

  src/l1-resources/custom-db-role/index.ts:69:18
    69 export interface Action {
                        ~~~~~~
    The declaring interface is introduced here
src/l1-resources/encryption-at-rest/index.ts:53:18 - error JSII5011: Submodule "aws_kms" conflicts with "AwsKms, as different languages could represent it as: "aws_kms", "awsKms", "AwsKms""

53 export interface AwsKms {
                    ~~~~~~

  node_modules/aws-cdk-lib/index.d.ts:142:13
    142 export * as aws_kms from './aws-kms';
                    ~~~~~~~
    This is the conflicting submodule declaration

Jira ticket: CLOUDP-Renames AwsKms to AwsKmsConfig in encryption-at-rest

Type of change:

Manual QA performed:

Required Checklist:

Further comments