mongodb / mongodbatlas-cloudformation-resources

MongoDB Atlas CloudFormation Resources: Deploy, update, and manage MongoDB Atlas infrastructure as code through AWS CloudFormation
https://www.mongodb.com/atlas/aws-cloudformation
Apache License 2.0
58 stars 38 forks source link

chore: Fixes the pagination for aws cloudformation list-type-versions #1129

Closed EspenAlbert closed 3 weeks ago

EspenAlbert commented 3 weeks ago

Proposed changes

Fixes the pagination for aws cloudformation list-type-versions

Link to any related issue(s): CLOUDP-268623

Successful run to test fix

Failed run for master

Relevant failing logs from s3 (similar execution role is used in all the 3 failed attempts):

[2024-08-19T09:12:43Z] DEBUG    - Running test: Namespace(version=False, subparser_name='test', command=<function test at 0x7fcd23c795e0>, verbose=0, endpoint='<https://lambda.ap-northeast-2.amazonaws.com>', function_name='MongoDB-Atlas-Cluster711489243244-Handler-1u0hypumvwcoc', region='ap-northeast-2', profile=None, role_arn='arn:aws:iam::711489243244:role/mongodb-atlas-cluster-role-stack-ExecutionRole-Ae24TDEYnNlX', cloudformation_endpoint_url=None, enforce_timeout='240', log_group_name=None, log_role_arn=None, passed_to_pytest=[], docker_image=None, typeconfig=None, source_account='711489243244', source_arn='arn:aws:cloudformation:ap-northeast-2:711489243244:type/resource/MongoDB-Atlas-Cluster/00000036')
Getting session token resulted in unknown ClientError. Could not assume specified role 'arn:aws:iam::711489243244:role/mongodb-atlas-cluster-role-stack-ExecutionRole-Ae24TDEYnNlX'.

Type of change:

Manual QA performed:

Required Checklist:

Further comments

EspenAlbert commented 3 weeks ago

Extra fix in 5bbcac4: Details: https://github.com/mvdan/sh/releases/tag/v3.9.0