CLOUDP-263207 Use internal OAS instead of fetching from s3 bucket - Githubissues

mongodb / openapi

MongoDB OpenAPI specs

Apache License 2.0

5 stars 7 forks source link

CLOUDP-263207 Use internal OAS instead of fetching from s3 bucket #175

Closed Luke-Sanderson closed 2 months ago

Luke-Sanderson commented 2 months ago

Proposed changes

Previous method

Fetch a list of current versions and store in a file named versions.json
Fetch the most recent version of the OAS from the s3 bucket.
Compare OAS with cached sha to determine if workflow should continue

Proposed method

Only will start on Prod OAS Release PR merge so always will be a new version of the OAS
Sort the files in the OpenAPI folder
Get the most recent OAS
Extract the version from the file name and store in a file version.txt

Advantages

Removes 2 API calls per run
Set to run only on merge of Prod OAS Release PR rather than Cron job

Tested on fork, note it only failed on the upload step due to secrets not being set. Output on the fetch step shows correct version.

Jira ticket: CLOUDP-263207

Checklist

[ ] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works

Further comments