mongodb / specifications

Specifications related to MongoDB
http://specifications.readthedocs.io/en/latest
Other
389 stars 242 forks source link

DRIVERS-2604 deduplicate encrypted fields files #1400

Closed kevinAlbs closed 1 year ago

kevinAlbs commented 1 year ago

Summary

There is no expected test coverage or behavior change.

Changes tested with C driver in this patch build: https://spruce.mongodb.com/version/6436ce262a60edecd5b8f761

Background & Motivation

Motivated by this comment: https://github.com/mongodb/specifications/pull/1396#discussion_r1162257008 The range-encryptedFields-*.json files and the encryptedFields-Range-*.json files are almost identical.

14c5099a65448f4397bf336c52f6ea048d855c91 adds contention to encryptedFields-Range-*.json. The server response to listCollections includes the default value chosen for contention. encryptedFields-Range-*.json is used both for collection creation and for the command_started event assertions. Without adding contention to the expected command_started event, the test assertion fails since the actual event contains the default contention.

9b2df75bc3c8139916dafbf3bd48ced852390179 uses $numberLong consistently for sparsity. The server accepts both $numberLong and $numberInt. The only motivation was for consistency.

Please complete the following before merging: