mongodb / specifications

Specifications related to MongoDB
http://specifications.readthedocs.io/en/latest
Other
389 stars 242 forks source link

DRIVERS-2581 specify bindings benchmark #1463

Closed kevinAlbs closed 1 year ago

kevinAlbs commented 1 year ago

Summary

The benchmark has been implemented in the libmongocrypt Java bindings here with support for multiple threads in review here: https://github.com/mongodb/libmongocrypt/pull/700#pullrequestreview-1639948555:

Background & Motivation

Benchmarking helped to measure performance related changes to libmongocrypt and Java bindings in MONGOCRYPT-589 and MONGOCRYPT-595.

Specifying the benchmark is intended to help language teams implement DRIVERS-2581.


Please complete the following before merging:

- [ ] Update changelog. N/A. Test changes only - [ ] Make sure there are generated JSON files from the YAML test files. N/A. No YAML files were changed

jyemin commented 1 year ago

Seems like we're no longer going to implement DRIVERS-2581. Is it relevant as a justification for this work?

kevinAlbs commented 1 year ago

I plan to revise and DRIVERS-2581 to suggest language bindings projects add benchmarks and use the newly exported mongocrypt_binary_t definition to improve performance.