mongodb / specifications

Specifications related to MongoDB
http://specifications.readthedocs.io/en/latest
Other
389 stars 242 forks source link

DRIVERS-2668 Add SRV test with uppercase hostname #1473

Closed ShaneHarvey closed 11 months ago

ShaneHarvey commented 11 months ago

DRIVERS-2668. Unfortunately, as noted in DEVPROD-174, it's not possible to add the exact test case I envisioned for DRIVERS-2668 (where DNS returns uppercase letters in the SRV result). However we can still add this related test case with uppercase letters in the initial SRV hostname.

Please complete the following before merging:

dariakp commented 11 months ago

@ShaneHarvey I was out on PTO when this landed. It looks like the original ticket has not been updated based on the most recent information about what's possible to test - could you add the new context to the ticket summary so that the final outcome (what we will actually test and what sort of bug this is meant to catch) is more obvious to the teams that go to implement this? Also, is this more limited test still sufficient to prevent the kind of issue that python originally ran into?

ShaneHarvey commented 11 months ago

I was planning to update the ticket description once this is merged.

Also, is this more limited test still sufficient to prevent the kind of issue that python originally ran into?

No. This test does not cover the bug in PYTHON-3800 but it's still useful because it ensures drivers normalize the hostname before SRV+TXT lookup.