DRIVERS-1150 Writes are not retried within transactions

mongodb / specifications

Specifications related to MongoDB

http://specifications.readthedocs.io/en/latest

Other

389 stars 242 forks source link

DRIVERS-1150 Writes are not retried within transactions #1481

Closed comandeo closed 10 months ago

comandeo commented 10 months ago

Please complete the following before merging:

[x] Update changelog.
[ ] Make sure there are generated JSON files from the YAML test files - not applicable.
[ ] Test changes in at least one language driver - not applicable.
[ ] Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless) - not applicable.

kkloberdanz commented 10 months ago

Hi Dmitry, is there any background information for this change that you would be able to share with us on this PR? Also, does it make sense to have a test for this behavior? Thank you.

comandeo commented 10 months ago

Hi Dmitry, is there any background information for this change that you would be able to share with us on this PR? Also, does it make sense to have a test for this behavior? Thank you.

Hi Kyle, as I understood the ticket, we just need to copy instructions from transactions spec to retryable writes spec. The behaviour is tested here

kkloberdanz commented 10 months ago

Hi Dmitry, is there any background information for this change that you would be able to share with us on this PR? Also, does it make sense to have a test for this behavior? Thank you.

Hi Kyle, as I understood the ticket, we just need to copy instructions from transactions spec to retryable writes spec. The behaviour is tested here

Sounds good to me, I'll approve.