Clarify zero-case connectTimeoutMS in SDAM setupConnection PC - Githubissues

mongodb / specifications

Specifications related to MongoDB

http://specifications.readthedocs.io/en/latest

Other

389 stars 242 forks source link

Clarify zero-case connectTimeoutMS in SDAM setupConnection PC #1496

Closed prestonvasquez closed 1 month ago

prestonvasquez commented 9 months ago

Please complete the following before merging:

[x] Update changelog.
[x] Test changes in at least one language driver.
[x] Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

We can't use a 0 connectTimeoutMS when creating a socket for monitoring, since that will result in a timeout error. IIUC we should not set a timeout, described here. This should be reflected in the psuedocode. This update is validated by this unified spec test: https://github.com/mongodb/specifications/blob/f1bbc245e68916ab76cb831f6372aa5d6a50ed25/source/server-discovery-and-monitoring/tests/unified/connectTimeoutMS.yml#L23

ShaneHarvey commented 1 month ago

@prestonvasquez are you planning to update this PR?