DRIVERS-1725 Unskip failCommand+appName tests on MongoDB 4.4.7+

mongodb / specifications

Specifications related to MongoDB

http://specifications.readthedocs.io/en/latest

Other

389 stars 242 forks source link

DRIVERS-1725 Unskip failCommand+appName tests on MongoDB 4.4.7+ #1612

Closed ShaneHarvey closed 2 months ago

ShaneHarvey commented 3 months ago

DRIVERS-1725

Please complete the following before merging:

[X] Make sure there are generated JSON files from the YAML test files.
[x] Test changes in at least one language driver. Testing Python here: https://github.com/mongodb/mongo-python-driver/pull/1735
[X] Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

ShaneHarvey commented 2 months ago

@dariakp do you plan to review this or do you want to defer to Warren's review?

dariakp commented 2 months ago

@dariakp do you plan to review this or do you want to defer to Warren's review?

@ShaneHarvey sorry I didn't see the review request, it must have come in while I was still out on leave. If @W-A-James ran all these tests in the Node CI, I can defer to his review, other than the one question.

ShaneHarvey commented 2 months ago

@qingyang-hu your review is required as the CSOT co-owner.

ShaneHarvey commented 2 months ago

Thanks all!