search

mongodb / stitch-ios-sdk

Apache License 2.0
42 stars 25 forks source link

STITCH-2216 Swift SDK: Happy path READ implementation in the Data Synchronizer #108

Closed jsflax closed 5 years ago

jsflax commented 5 years ago

Count, Find, and Aggregate in CoreSync => DataSynchronizer.

jsflax commented 5 years ago

But throw what error?

On Mon, 26 Nov 2018 at 13:29, Adam Chelminski notifications@github.com wrote:

@adamchel commented on this pull request.

In Core/Services/StitchCoreRemoteMongoDBService/Sources/StitchCoreRemoteMongoDBService/Sync/DataSynchronizer.swift https://github.com/mongodb/stitch-ios-sdk/pull/108#discussion_r236374046 :

@@ -327,8 +329,13 @@ public class DataSynchronizer: NetworkStateListener, FatalErrorListener { */ func count(filter: Document, options: CountOptions?,

  • in namespace: MongoNamespace) {
  • fatalError("(#function) not implemented")
  • in namespace: MongoNamespace) throws -> Int {
  • let lock = self.syncConfig[namespace]?.nsLock ?? syncLock

I know subscripts can't throw, which is why I suggested for this method to throw.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mongodb/stitch-ios-sdk/pull/108#discussion_r236374046, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJ7QIPFimHtP4lLTjZZzCparFpI0_WOks5uzDMLgaJpZM4YtNJh .