search

mongodb / stitch-ios-sdk

Apache License 2.0
42 stars 25 forks source link

STITCH-2844 Swift SDK: Fix Update => Update, Update => Replace, Replace => Update Coalescence #178

Closed jsflax closed 4 years ago

jsflax commented 5 years ago

Yep, quick drive by

On Tue 23 Apr 2019 at 18:09, Douglas Kaminsky notifications@github.com wrote:

@dkaminsky approved this pull request.

lgtm - was the formatting fix intended?

In Core/StitchCoreSDK/Tests/StitchCoreSDKTests/Auth/Internal/AccessTokenRefresherUnitTests.swift https://github.com/mongodb/stitch-ios-sdk/pull/178#discussion_r277891644 :

@@ -10,7 +10,9 @@ import SwiftJWT var ufreshJWT = JWT.init(claims: ClaimsStandardJWT.init(exp: Date().addingTimeInterval(20 * 60))) let freshJWT = try! ufreshJWT.sign(using: JWTSigner.hs256(key: "secret".data(using: .utf8)!))

-var uexpiredJWT = JWT.init(claims: ClaimsStandardJWT.init(exp: Date().addingTimeInterval(-(Date.init().timeIntervalSince1970 - 10000.0)))) +var uexpiredJWT = JWT.init(

formatting fix?

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/mongodb/stitch-ios-sdk/pull/178#pullrequestreview-229821092, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBHWQFPPEZSLTKWZ6IHV63PR6CH7ANCNFSM4HH6TY7A .