mongodb / terraform-provider-mongodbatlas

Terraform MongoDB Atlas Provider: Deploy, update, and manage MongoDB Atlas infrastructure as code through HashiCorp Terraform
https://registry.terraform.io/providers/mongodb/mongodbatlas
Mozilla Public License 2.0
241 stars 169 forks source link

fix: Exposes role_mapping_id for federated_settings_org_rolemapping #2258

Closed EspenAlbert closed 4 months ago

EspenAlbert commented 4 months ago

Description

Exposes role_mapping_id for federated_settings_org_rolemapping

Before this change, you had to Base64 decode the .id to find the role_mapping_id, this exposes the field directly

Link to any related issue(s): CLOUDP-248288

Type of change:

Required Checklist:

Further comments

acceptance test (updated)

image

EspenAlbert commented 4 months ago

@oarbusi if the user wants to import the resource in another configuration or modify it with another tool. The same way, we expose the id of almost any other resource. Right now, they can find the role_mapping_id, but they would need to Base64 decode the id and do string parsing to find the role_mapping_id 😅

EspenAlbert commented 4 months ago

No approval from the docs team, but merging this after waiting more than 24 hours 👍