So I worked backwards from the test that was able to trigger the bug and I added the test features to make sure cloud_provider_access_authorization tests are more robust.
In a nutshell, feature_ids are empty if there isn't federated database (or something similar) associated to it. That's why I am adding it.
One might argue that this is similar to the test in federated_database_instance, but in reality it shouldn't be a concern. Practically these resources are almost always touched independently, so it's better to keep tests in both of them
[ ] Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
[ ] New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
[x] I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
[x] I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code
[x] If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
[x] If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.
oarbusi
commented
1 month ago
Description
In https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/8994019768 we noticed that cloud_provider_access_authorization tests are not robust enough and a bug introduced in it was spotted with other tests workflows in the Test Suite (that are using cloud_provider_access_authorization).
So I worked backwards from the test that was able to trigger the bug and I added the test features to make sure cloud_provider_access_authorization tests are more robust. In a nutshell, feature_ids are empty if there isn't federated database (or something similar) associated to it. That's why I am adding it.
One might argue that this is similar to the test in federated_database_instance, but in reality it shouldn't be a concern. Practically these resources are almost always touched independently, so it's better to keep tests in both of them
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-248348
Type of change:
Required Checklist:
Further comments