fix: Calls DeleteExportBucket before checking the status to catch any errors.

marcosuma commented 4 months ago

While trying to delete the snapshot export bucket resource, we noticed that the deletion hanged. The cause is due to the fact that we don't call the Delete API before checking the status update.

In addition, I've activated the related tests to be included in the nightly and PR run. There wasn't really any strong reason not to do that, since we can create S3 buckets, policies and anything else needed.

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

[x] Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
[ ] New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
[ ] This change requires a documentation update
[ ] Documentation fix/enhancement

Required Checklist:

[x] I have signed the MongoDB CLA
[x] I have read the contributing guides
[x] I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
[x] I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code
[x] If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
[x] If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

github-actions[bot] commented 4 months ago

APIx bot: a message has been sent to Docs Slack channel

marcosuma commented 4 months ago

The test TestAccBackupSnapshotExportBucket_basic itself is passing but overall some other tests are failing, also in the nightly run: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/9087917355/job/24976644413

I've tried many times to make them run successfully, but I think it's safe to go ahead and merge this one.

mongodb / terraform-provider-mongodbatlas