mongodb / terraform-provider-mongodbatlas

Terraform MongoDB Atlas Provider: Deploy, update, and manage MongoDB Atlas infrastructure as code through HashiCorp Terraform
https://registry.terraform.io/providers/mongodb/mongodbatlas
Mozilla Public License 2.0
241 stars 169 forks source link

chore: Enables and refactors TestAccBackupRSCloudBackupSchedule_export test. #2273

Closed marcosuma closed 4 months ago

marcosuma commented 4 months ago

Description

This test was disabled from CI because it needed AWS configuration. Since this is not really a blocker, I am proposing some changes and activate it.

Type of change:

Required Checklist:

Further comments

marcosuma commented 4 months ago

@EspenAlbert

Maybe we can create an acc helper for the boilerplate resources?

I tend to prefer that the test definition should all be together, verbosity and repetition in test is not a bad thing, actually the opposite because it makes the understanding process way faster.

Said that, I think it could be a future refactoring, for now let's just make sure we can rely on these tests.

Note also I had to make some further changes because the test was actually broken and wasn't easily to figure because of some unrelated flakyness.

marcosuma commented 4 months ago

Unrelated test TestAccBackupRSOnlineArchiveWithProcessRegion is failing, overall backup test suite is being flaky in the last few days. Going ahead with merging this.