mongodb / terraform-provider-mongodbatlas

Terraform MongoDB Atlas Provider: Deploy, update, and manage MongoDB Atlas infrastructure as code through HashiCorp Terraform
https://registry.terraform.io/providers/mongodb/mongodbatlas
Mozilla Public License 2.0
241 stars 169 forks source link

doc: Sets num_shards in advanced_cluster documentation as not always required. #2284

Closed marcosuma closed 4 months ago

marcosuma commented 4 months ago

Description

As mentioned in #2240, num_shards in advanced_configuration is not always required. For example:

resource "mongodbatlas_advanced_cluster" "this" {
  project_id                     = var.project_id
  name                           = "advanced-cluster-0"
  mongo_db_major_version         = "6.0"
  termination_protection_enabled = false
  cluster_type                   = "REPLICASET"

  replication_specs {
    region_configs {
      electable_specs {
        instance_size = "M10"
        node_count    = 3
      }
      analytics_specs {
        instance_size = "M10"
        node_count    = 1
      }
      provider_name = "AWS"
      priority      = 7
      region_name   = "US_EAST_1"
    }
  }
}

doesn't need it and I believe that if you pass it, TF apply will actually fail.

Fixing the documentation so that we remove the Required attribute.

Link to any related issue(s): #2240

Type of change:

Required Checklist:

Further comments

github-actions[bot] commented 4 months ago

APIx bot: a message has been sent to Docs Slack channel