mongodb / terraform-provider-mongodbatlas

Terraform MongoDB Atlas Provider: Deploy, update, and manage MongoDB Atlas infrastructure as code through HashiCorp Terraform
https://registry.terraform.io/providers/mongodb/mongodbatlas
Mozilla Public License 2.0
230 stars 167 forks source link

chore: Disables migration test for backup snapshot export until next release version. #2288

Closed marcosuma closed 1 month ago

marcosuma commented 1 month ago

Description

Follow-up from https://github.com/mongodb/terraform-provider-mongodbatlas/pull/2274 The migration test needs to be disabled since it would actually need us to define the ID properly (and not just any value). I am not sure how I managed to make it successful locally but test was failing since the weekend: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/9151546873/job/25157755777

Link to any related issue(s): CLOUDP-249082

Type of change:

Required Checklist:

Further comments

marcosuma commented 1 month ago

executed the test for two times: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/9155019403/job/25168593840?pr=2288

but they are failing at the same place of un unrelated test:

Error: -20T09:12:54.517Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccBackupRSOnlineArchiveWithProcessRegion test_terraform_path=/home/runner/work/_temp/a821a4f9-3c22-4498-aee5-2e31235767db/terraform test_working_directory=/tmp/plugintest1718490434 test_step_number=1 error="Check failed: Check 1/1 error: cluster(664b0a7afe5fdc7345c62f0d:664b0f48227f1c4b6f076b44) working sample data set error FAILED"
=== NAME  TestAccBackupRSOnlineArchiveWithProcessRegion
    resource_online_archive_test.go:183: Step 1/4 error: Check failed: Check 1/1 error: cluster(664b0a7afe5fdc7345c62f0d:664b0f48227f1c4b6f076b44) working sample data set error FAILED
querying for job 
Error: -20T09:12:54.617Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccBackupRSOnlineArchive test_terraform_path=/home/runner/work/_temp/a821a4f9-3c22-4498-aee5-2e31235767db/terraform test_working_directory=/tmp/plugintest3344522499 test_step_number=1 error="Check failed: Check 1/1 error: cluster(664b0a7a227f1c4b6f0761b9:664b0f48fe5fdc7345c63a4c) working sample data set error FAILED"
=== NAME  TestAccBackupRSOnlineArchive
    resource_online_archive_test.go:32: Step 1/7 error: Check failed: Check 1/1 error: cluster(664b0a7a227f1c4b6f0761b9:664b0f48fe5fdc7345c63a4c) working sample data set error FAILED
--- FAIL: TestAccBackupRSOnlineArchive (2632.70s)
--- FAIL: TestAccBackupRSOnlineArchiveWithProcessRegion (2672.84s)

The test I've changed to be skipped is instead working correctly:

=== RUN   TestMigBackupSnapshotExportJob_basic
    resource_cloud_backup_snapshot_export_job_migration_test.go:10: Skipping because version 1.16.0 below 1.16.1
--- SKIP: TestMigBackupSnapshotExportJob_basic (0.00s)