mongodb / terraform-provider-mongodbatlas

Terraform MongoDB Atlas Provider: Deploy, update, and manage MongoDB Atlas infrastructure as code through HashiCorp Terraform
https://registry.terraform.io/providers/mongodb/mongodbatlas
Mozilla Public License 2.0
244 stars 172 forks source link

[Bug]: Fields marked as sensitive unnecessarily? #2397

Closed throwaway58383958484 closed 3 months ago

throwaway58383958484 commented 4 months ago

Is there an existing issue for this?

Provider Version

v1.17.3

Terraform Version

v1.9.1

Terraform Edition

Terraform Open Source (OSS)

Current Behavior

On the mongodbatlas_x509_authentication_database_user resource, the fields current_certificate and customer_x509_cas are marked as sensitive (code). From my understanding, these values are not actually sensitive/secret. Is there context here that I'm missing?

We have internal tooling that blocks committing secrets to Terraform state, and we currently make an exception for this resource, but if it's true that these don't need to be sensitive, and they were no longer marked as such, then we could remove the exception.

Terraform configuration to reproduce the issue

resource "mongodbatlas_x509_authentication_database_user" "user" {
  project_id = "..."
  customer_x509_cas = "..."
}

Steps To Reproduce

Run a plan: the customer_x509_cas attribute is considered sensitive and is redacted in the plan.

Logs

No response

Code of Conduct

github-actions[bot] commented 4 months ago

Thanks for opening this issue! Please make sure you've followed our guidelines when opening the issue. In short, to help us reproduce the issue we need:

The ticket CLOUDP-260892 was created for internal tracking.

AgustinBettati commented 4 months ago

Hello @throwaway58383958484.

Some details regarding both attributes:

Will let you know once we have updates.

github-actions[bot] commented 3 months ago

This issue has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!