search

mongodb / terraform-provider-mongodbatlas

Terraform MongoDB Atlas Provider: Deploy, update, and manage MongoDB Atlas infrastructure as code through HashiCorp Terraform
https://registry.terraform.io/providers/mongodb/mongodbatlas
Mozilla Public License 2.0
241 stars 167 forks source link

In recommendations, prevent export of keys appearing in OS history #261

Closed pkdone closed 4 years ago

pkdone commented 4 years ago

In MongoDB Atlas Provider landing page (also in README of this project)...

For section:

Usage:

$ export MONGODB_ATLAS_PUBLIC_KEY="xxxx"
$ export MONGODB_ATLAS_PRIVATE_KEY="xxxx"
$ terraform plan

Change to: 

Usage (prefix the export commands with a space to avoid the keys being recorded in OS history):

$  export MONGODB_ATLAS_PUBLIC_KEY="xxxx"
$  export MONGODB_ATLAS_PRIVATE_KEY="xxxx"
$ terraform plan

As a result, running history afterwards from a new terminal session will not show the values of the keys.

themantissa commented 4 years ago

@pkdone a good suggestion, I'll add this in a small PR and have you review.

themantissa commented 4 years ago

https://github.com/terraform-providers/terraform-provider-mongodbatlas/pull/263 < @pkdone take a look, pretty small so quick to add

themantissa commented 4 years ago

Completed.