support building with mingw

mongodb / winkerberos

A native Kerberos client implementation for Python on Windows

Apache License 2.0

54 stars 15 forks source link

support building with mingw #21

Closed totaam closed 5 years ago

totaam commented 6 years ago

Please consider applying the patch below to support building winkerberos with mingw: mingw build patch

behackett commented 6 years ago

Thanks for working on this patch. I have a few questions.

Why do you have to check an environment variable for find mingw? Python's distutils should be able to find it automatically. For example, "python setup.py build_ext -c mingw32".
I'm guessing you are using Mingw-w64?
I'm also just curious why you are building WinKerberos from source? There are pre-built wheels on pypi.

totaam commented 6 years ago

IIRC there is a more "correct" way of detecting a mingw build, but I can't remember what it is
yes, mingw-w64
re: "why build from source", mostly personal preference: if we can't build something from source, we tend to not trust our ability to maintain a working system in the long run - pypi wheels are great, but being able to modify the source and rebuild (for debugging or whatever) - or being able to use the same compiler (gcc vs msvc) - all those things matter to us

behackett commented 6 years ago

OK, thanks. I have slightly mixed feelings about supporting mingw, but I do fear that Microsoft will eventually stop distributing the Visual C++ Compiler for Python 2.7, and setting up a build environment for Python 3.3 / 3.4 is a pain if you don't have access to a copy of Visual Studio 2010.

behackett commented 6 years ago

Would you like to send a pull request that I can review and merge? If not, I can copy from the link you provided.

totaam commented 5 years ago

Bump.

behackett commented 5 years ago

This was resolved by #22