search

mongodb / winkerberos

A native Kerberos client implementation for Python on Windows
Apache License 2.0
54 stars 15 forks source link

None channel_bindings not supported for authGSSClientStep #49

Closed CravateRouge closed 2 years ago

CravateRouge commented 2 years ago

None is currently not supported when calling:

winkerberos.authGSSClientStep(ctx, base64.b64encode(in_token).decode('utf-8'), 
                                        channel_bindings=None) 
TypeError: Expected a channel bindings object

I saw a similar issue here: https://bugzilla.redhat.com/show_bug.cgi?id=1354334

behackett commented 2 years ago

It works this way to match how ccs-pykerberos works, though I agree it's a bit annoying it you want to write code that might optionally use channel bindings.

CravateRouge commented 2 years ago

I understand, I let you close this issue if you estimate it's better to stay that way. Thanks :)

behackett commented 2 years ago

If you would like to send a pull request to have that option accept None, I'd be open to merging it.