mongofill / mongofill-hhvm

A mix of the original Mongofill extension + BSON implementation in C++
MIT License
32 stars 19 forks source link

Compiling with "mongofill/mongofill" master #24

Closed digitalkaoz closed 9 years ago

digitalkaoz commented 9 years ago

Hey,

if i want to try to compile it with latest master of https://github.com/mongofill/mongofill i get errors when trying to start hhvm with this extension.

Systemlibsystemlib.phpmongo' contains a fataling unit: Namespace declaration statement has to be the very first statement in the script: (Line: 4288, Char: 21), 4288`

i viewed the src/ext_mongo.phpand noticed that the global classes are not wrapped in a global namespace :


namespace {
  class MongoClient(){}
}

namespace Mongofill {
...
}

i think the merge script should respect that