mongoid / mongoid-grid_fs

A pure Mongoid/Moped implementation of the MongoDB GridFS specification.
Other
83 stars 50 forks source link

Fix gemspec and update readme. #42

Closed mattconnolly closed 10 years ago

rmm5t commented 10 years ago

Thanks. I'm all for this kind of change, but I think @ahoward generates the gemspec from a rake task. See rake gemspec; although, I can't get those tasks to run properly. :grimacing:

Ideally, I'd like to see this gem just managed by some pre-baked bundler tasks.

I don't think @ahoward subscribes to any github notifications, so we might need to email him directly for direction feedback here.

mattconnolly commented 10 years ago

Are there any other gems out there that dynamically generate these files? I haven't seen any, so it seems odd to me.

If the files are intended to be generated, then shouldn't they be ignored by git?

gemspecs are already executable code, what is the benefit of generating code with code?

rmm5t commented 10 years ago

Are there any other gems out there that dynamically generate these files? I haven't seen any, so it seems odd to me.

Yes. This is common practice amongst the old-school types and the Seattle.rb crew, especially those that like to use hoe. See minitest. I'm not a fan though.

If the files are intended to be generated, then shouldn't they be ignored by git?

Perhaps, but bundler expects gems specified by a git repository to have a gemspec in the git repository.

gemspecs are already executable code, what is the benefit of generating code with code?

Preaching to the choir. I prefer an executable gemspec and gem release management via bundler/gem_tasks.


Because I don't have gem push rights for this project, I'm hesitant to make any changes that would change @ahoward's workflow -- even though switching to an executable gemspec and bundler/gem_tasks would clean up hundreds of lines of code in the Rakefile and would make it easier to fix the (currently brittle) gemspec generation.

ahoward commented 10 years ago

@mattconnolly


# say you maintain about 150 gems, then you might want to ->

for d in git/ahoward/*;do pushd .; cd $d; cp ../Rakefile .; rake gem; done

and yes, gemspecs should never be .gitignored or it makes local development or bundler development impossible (gem 'foo', :path => ...)

ahoward commented 10 years ago

@rmm5t since i'm getting lots of help on this project i don't mind changes that help you commit and release. thoughts?

rmm5t commented 10 years ago

@ahoward Cool. As soon as I get a chance, I'll take a look at porting some things to make it easier for myself and outsiders to contribute. I'm glad to take on shared responsibility for gem push rights on rubygems.org. :beers:

Meanwhile, if you could also enable Travis builds for https://travis-ci.org/ahoward/mongoid-grid_fs, that would be stellar too.

ahoward commented 10 years ago

@rmm5t


a:~/git/ahoward/mongoid-grid_fs $ gem owner mongoid-grid_fs --add ryan@mcgeary.org
Owner added successfully.
Owners for gem: mongoid-grid_fs
- ryan@mcgeary.org
- ara.t.howard@gmail.com
ahoward commented 10 years ago

@rmm5t

rmm5t commented 10 years ago

Thanks @ahoward!

Thanks @mattconnolly!