search

mongoid / mongoid-grid_fs

A pure Mongoid/Moped implementation of the MongoDB GridFS specification.
Other
83 stars 50 forks source link

Support for mongoid 7 #74

Closed asgerb closed 6 years ago

asgerb commented 6 years ago

This should add support for mongoid 7, which did not require changes to the code. Test suite runs green locally at least 🙂

I added a new Gemfile for mongoid 7 and changed the version in the gemspec.

mongoid-bot commented 6 years ago
1 Message
:book: We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by :no_entry_sign: danger

dblock commented 6 years ago

Somewhat simpler version in https://github.com/mongoid/mongoid-grid_fs/pull/73.

dblock commented 6 years ago

I was hoping @ahoward or @asgerb could merge #73 (or this one), but if we don't hear from them I can do it soon.

asgerb commented 6 years ago

Hey @dblock, I missed your PR, sorry about the added clutter!

asgerb commented 6 years ago

Oh and I'm not a maintainer, so unfortunately I can't merge your (better) PR 😉 I will go ahead and close this in favor of your PR.

dblock commented 6 years ago

Ah yes sorry, I meant to bump @rmm5t