Ensure we find the correct Regexp::Raw class

mongoid / mongoid-slug

Generates a URL slug/permalink based on fields in a Mongoid-based model.

https://github.com/mongoid/mongoid-slug

MIT License

492 stars 164 forks source link

Ensure we find the correct Regexp::Raw class #240

Closed artfuldodger closed 7 years ago

artfuldodger commented 7 years ago

With mongoid 5.2.1's addition of the Origin::Extensions::Regexp::Raw module, the constant lookup was ambiguous.

Here's the exception I was seeing:

NoMethodError:
  undefined method `new' for Origin::Extensions::Regexp::Raw:Module
# /home/rof/cache/bundler/ruby/2.4.0/gems/mongoid-slug-5.3.2/lib/mongoid/slug/unique_slug.rb:133:in `regex_for_slug'

mongoid-bot commented 7 years ago

	1 Warning
:warning:	There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by :no_entry_sign: danger

dblock commented 7 years ago

Merged thanks, @mzikherman want to cut an update?

mzikherman commented 7 years ago

Yup, will release this as 5.3.3, thanks for fixing @artfuldodger!

mzikherman commented 7 years ago

Released as 5.3.3.