search

mongoid / origin

A Ruby DSL for building MongoDB queries
http://mongoid.org/en/origin/index.html
MIT License
62 stars 29 forks source link

MONGOID-3639 add merging of selectors with either '$nor' or '$nin' operators, rather than overwriting #113

Closed DiannaHohensee closed 8 years ago

DiannaHohensee commented 8 years ago

@estolfo Fixed.

estolfo commented 8 years ago

After taking the spec_helper change out and rebasing against master, it looks good to me. Thanks!

DiannaHohensee commented 8 years ago

@estolfo spec_helper change removed and rebased.

estolfo commented 8 years ago

One more thing: the syntax you're using in the tests

{ "$nin": ["foo"] }

doesn't work on older versions of Ruby. You can see the test failures here: https://travis-ci.org/mongoid/origin/builds/89066063 You'll need to update the syntax to be:

{ "$nin" => ["foo"] }
DiannaHohensee commented 8 years ago

@estolfo Fixed. Seems to pass now.