search

mongolab / mongoctl

Manage MongoDB servers and replica sets using JSON configurations!
MIT License
178 stars 25 forks source link

reconsider logic for considering member as joined replica #38

Closed abdulito closed 7 years ago

abdulito commented 7 years ago 

    def has_joined_replica(self):
        master_result = self.is_master_command()
        if master_result:
            return (master_result.get("setName") is not None or
                    master_result.get("ismaster") or
                    master_result.get("arbiterOnly") or
                    master_result.get("secondary"))

Do we need master_result.get("setName") is not None ??

https://github.com/mongolab/mongoctl/blob/2caecd0b75c5b65e00f2580eee7014a99bf7ed16/mongoctl/objects/mongod.py#L280-L280

abdulito commented 7 years ago

https://github.com/mongolab/mongoctl/commit/8089bf7183656677801df8d6bd4cafaefd30e8e3