Closed skanehira closed 3 months ago
@skanehira Thanks for your first contribution.
I think the reason for the failure of test github action is that the existing configuration is not authoritative enough. I will check with you later, but you are welcome to handle this on your end.
test shell script may not be a concern once the test results are unstable. I'll check it later on my end.
@skanehira I did some research. #36
If not forking, the current settings seemed to work fine. 987e6d1
The required permissions were as follows. 99de72a Could you please add the permission settings as well and push?
Added permissions
Thank you for your response. However, it doesn't seem to be working. https://github.com/mongolyy/reviewdog-action-biome/actions/runs/8410034096/job/23034283589
I see in the log that the check permission is set to read.
I will investigate today why this is happening. I'm assuming it's a result of the settings in github, but if you know anything about it on your end, I'd appreciate it if you could let me know!
Added permissions
Thank you for your response. However, it doesn't seem to be working. https://github.com/mongolyy/reviewdog-action-biome/actions/runs/8410034096/job/23034283589
I see in the log that the check permission is set to read.
I will investigate today why this is happening. I'm assuming it's a result of the settings in github, but if you know anything about it on your end, I'd appreciate it if you could let me know!
Humm... I try added this settings but it didn't works. I'll take a look later 🙏
pull-requests: write
checks: write
contents: read
@skanehira
I try added this settings but it didn't works.
Thank you for trying. I think it is difficult to give write permission for forked repositories with the current trigger. https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
Need to change test to fix this problem, but difficult to do right away. I'm not sure how to fix this problem.
On the other hand, we think this defect should be resolved as soon as possible. Since we have confirmed that the test succeeds even in #36, we are willing to tolerate the fact that the test is failing.
If you can revert the changes in .github/workflows/test-action.yml
, I will approve and merge this.
@skanehira
I try added this settings but it didn't works.
Thank you for trying. I think it is difficult to give write permission for forked repositories with the current trigger. https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
Need to change test to fix this problem, but difficult to do right away. I'm not sure how to fix this problem.
On the other hand, we think this defect should be resolved as soon as possible. Since we have confirmed that the test succeeds even in #36, we are willing to tolerate the fact that the test is failing.
If you can revert the changes in
.github/workflows/test-action.yml
, I will approve and merge this.
@mongolyy Thank you :) I removed permissions
🚀 [bumpr] Bumped! New version:v1.3.2 Changes:v1.3.1...v1.3.2
Fix this error when I use workdir