mongolyy / reviewdog-action-biome

MIT License
35 stars 4 forks source link

Missing comments #43

Open arienshibani opened 7 months ago

arienshibani commented 7 months ago

Action suggest many changes, but no comments

I reckon i am missing some sort of setting in my YAML file?

name:  Reviewdog
on: workflow_dispatch
jobs:
  biome:
    name: Linter 🧹
    runs-on: ubuntu-latest
    permissions:
      contents: read
      pull-requests: write
    steps:
      - name: Check out code.
        uses: actions/checkout@v4
      - name: lint
        uses: mongolyy/reviewdog-action-biome@v1.2.0
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          reporter: github-pr-review

This is what i am trying to achieve:

image

But this is what it currently looks like on my end

image

mongolyy commented 7 months ago

Thanks for the question.

Your settings are correct.

If you are using github-pr-review at reporter, the behavior is to suggest the result of the modification using biome apply, so it will not comment! If you really want to comment, you can set up github-pr-check as a reporter. However, this is not recommended because it will not provide commit suggestions.

I would like to see if there are any other similar opinions or reactions to this Issue and make a decision.