Add int characteristic - Githubissues

mongoose-os-libs / homekit-adk

Port of Apple's HomeKit ADK to Mongoose OS

Apache License 2.0

23 stars 5 forks source link

Closed jobl1978 closed 3 years ago

jobl1978 commented 3 years ago

Added missing int characteristic. Light bulb service is using this characteristic for brightness.

rojer commented 3 years ago

lgtm but please revert irrelevant formatting changes. this file is formatted by clang-format to conform to apple style.

jobl1978 commented 3 years ago

lgtm but please revert irrelevant formatting changes. this file is formatted by clang-format to conform to apple style.

clang-format did this automatically with the current .clang-format file that is provided in this project

bool and float also have those indents, there was somethings mixed before

rojer commented 3 years ago

ah, my apologies, must've been introduced in previous PRs. i ran clang-format and pushed a separate commit

rojer commented 3 years ago

please rebase

jobl1978 commented 3 years ago

please rebase

Done

rojer commented 3 years ago

merged, thanks!