search

mongoosejs / kareem

Next-generation take on pre/post function hooks
Apache License 2.0
82 stars 8 forks source link

[Docs] it's not clear what `done` refers to in execPre(...) examples #14

Closed AbdelrahmanHafez closed 4 years ago

AbdelrahmanHafez commented 4 years ago

In the first example of the docs, what does done refer to? I thought it was a missing parameter for the callback parameter that's passed to execPre(...), but I noticed it's consistently not mentioned everywhere where execPre(...) is used.

vkarpov15 commented 4 years ago

Fixed. The done() in the examples is Mocha's done(), because we generate the README examples from our mocha tests.