Using dockerd as docker daemon has been deprecated

mongrelion / ansible-role-docker

Ansible role for installing Docker

MIT License

62 stars 39 forks source link

Using dockerd as docker daemon has been deprecated #24

Closed ageekymonk closed 6 years ago

ageekymonk commented 6 years ago

Fix for #22

mongrelion commented 6 years ago

@marcusianlevine before you merge this could you please make sure that it doesn't break any previous supported version that we offer? I know this sucks to have to manually test this. We really need those integration tests ;_;

marcusianlevine commented 6 years ago

I ran the build locally and everything worked fine, but as-is this change will break backwards compatibility with versions of Docker <1.13

Do we intend to support 1.12 and below? For reference, Rancher's setup scripts support down to 1.10

If so, we need to add a conditional that checks the Docker version and decides which daemon command to use.