Closed paulfantom closed 6 years ago
Hello, @paulfantom
Thanks for this PR. Did you test this locally to make sure that you didn't break the role? :)
@paulfantom that would be awesome. I find myself asking this question over and over again on the PRs because we don't have an integration tests suite yet in place :( See https://github.com/mongrelion/ansible-role-docker/issues/13
If you think that you can take care of that, then I'll let you submit a PR for it first, then once that's merged, merge this one. Otherwise you'll have to wait for someone else to be able to pick this up and ensure that your changes don't break backwards compatibility.
Let me know what are your thoughts.
Ok, this seems to be going nowhere with the tests. I thought for a second to merge this as it is but it seems like more people are depending on this role and we need to be wary of not breaking compatibility. So, until we don't have a proper test suite in place, I'm going to hold all pull requests back.
Sorry about this.
I have totally forgot about it. However look at #30.
@paulfantom could you please rebase with master as to trigger the CI pipeline again?
Done
This looks good. Let's get it merged. Thanks again for your help, @paulfantom
According to systemd docs and ways of packaging applications you shouldn't overwrite systemd service file in /usr/lib/systemd/system/ since this file will be overwritten by package installer on update. Safe place for storing service files is in /etc/systemd/system and this PR fixes this.