search

monicahq / monica

Personal CRM. Remember everything about your friends, family and business relationships.
https://beta.monicahq.com
GNU Affero General Public License v3.0
21.45k stars 2.14k forks source link

Upgrade to Font Awesome 5 #1780

Open FranklinYu opened 6 years ago

FranklinYu commented 6 years ago

Anyone interested in upgrading Font Awesome to 5? There is free version available, with some icons added. This is one of the new icons. I’m not aware of any removal.

djaiss commented 6 years ago

What would be the main value?

FranklinYu commented 6 years ago

The icon I mentioned above stands for a social network that I want to add to my Monica.

Zegnat commented 4 years ago

Found this issue over a year after it was opened, haha. Would a PR for this be appreciated? Happy to make one.

Font Awesome 5 includes 448 free icons in the brand category. These would be great when I am adding links to my contacts. Just today I wanted to separate Facebook from Messenger links (in part so I could set the protocol to https://www.messenger.com/t/ and get immediate links to the conversations) and when I went to set the Messenger logo I found out Monica is still on FA4 which does not include it.

If there are misgivings about the new licensing model of FA since the 4→5 upgrade, I would propose packaging simple-icons instead. This would give Monica users access to over a 1000 (currently 1382) brand icons to use when customising their contacts.

k3davis commented 2 years ago

My preference (fwiw, not much) would be to use FA5/6 here, and for there to be a setting perhaps that allows a person with a pro account to pull that - APi key, link to a specific set, etc. But simple-icons as @Zegnat suggested would also be a viable alternative for me.

FA4 icons are quite old now and numerous icons (especially brands, used for contact methods) are outdated or missing.

virtadpt commented 2 years ago

Why not migrate to Fork Awesome? No truncated set of icons, no API key needed.

d-leb commented 2 years ago

I'm glad to see people talking about this. I would like to help out if I can. I started using Monica again recently after realizing that I do need something to help remind me to keep in touch with people. I tried adding Discord as a contact type and I quickly realized that we are missing out on a lot of the branded icons that have been added over the past few years. I can help make a PR, but if we were going to migrate to FA6, I believe we would need to change the fa classname to the appropriate name of the icon set. For example, with the Facebook icon, fa fa-facebook-official would become fa-brands fa-facebook-square.

Since it has changed a few times (in FA5 it was something different), I would also suggest if we make this change we use a backed enum so we can change the class paths in the enum's string values if it changes again in the future.

The same holds true with Fork Awesome - fa fa-facebook-official would become fa fa-facebook-square.

Ryonez commented 2 years ago

Huh, this would explain why I can't use the discord icon.

phorcys420 commented 1 year ago

Huh, this would explain why I can't use the discord icon.

yeah, would be nice if there was some news on this

Dalethium commented 1 year ago

I would love this! Fork awesome is also a great idea as @virtadpt said!

ghost commented 1 year ago

Hey, I patched font-awesome in app-ltr.scss and found no missing icons or broken references.

Edit: Had the sort icon broken on the contacts page, I swapped out the font family in people.scss and settings.scss and that works fine too.

It seems like this is pretty trivial unless there's something I missed something.

The same holds true with Fork Awesome - fa fa-facebook-official would become fa fa-facebook-square

Isn't fa-facebook-official the same as fa fa-facebook-square? I replaced font-awesome with fork-awesome in here and I don't see a difference.

ojhernandez commented 1 year ago

Huh, this would explain why I can't use the discord icon.

Are there any updates on this? Tried for a bit to get the Discord icon to show up to no avail before searching GitHub for issues and saw that it's related to the Font Awesome version.

Is there any work around?

It's not the end of the world but would be a nice to have for consistency sake on my end! :)

pmlandwehr commented 1 year ago

I too, would like to have support for the Discord icon!

It's not the end of the world but would be a nice to have for consistency sake on my end! :)

It's not the end of the world, but it's definitely a readability issue.

Dalarialus commented 1 week ago

I'd also support this, if for no other reason than being able to add the discord icon.

Referenced in this Stack Overflow discussion.