Wrong URL in email (containing localhost)

[chevdor]

⚠️ This issue respects the following points: ⚠️

• [X] This is a bug, not a question or a configuration/webserver/proxy issue.
• [X] This issue is not already reported on Github (I've searched it).
• [X] I agree to follow Monica's Code of Conduct.

Bug description

Wrong URL in email (containing localhost)

Steps to reproduce

1. Setup APP_URL. ie APP_URL: monica.mydomain.com
2. Get a reminder email
3. See the URL in the email, it will be https://localhost/monica.mydomain.com/people/<...> instead of https://monica.mydomain.com/people/<...>

Expected behavior

The link in the email follows the APP_URL.

Environment

Your own self-hosted instance (monica v4)

Version of Monica

4.0.0

Installation method

Docker / k8s

Web server

Traefik / nginx

Database engine version

MariaDB

Additional info

I made an attempt to use APP_URL: https://monica.mydomain.com. I am now waiting for the next reminders to see whether that helps.

[chevdor]

...and that did the trick.

TODO

• [ ] update the doc to mention that APP_URL should be defined as APP_URL: https://monica.mydomain.com and not APP_URL: monica.mydomain.com
• [ ] fix the code so that APP_URL: monica.mydomain.com does work, there is no reason to slide a localhost in there

[Mr1131]

i would like to contribute on same.