search

monich / sailfish-barcode

Barcode reader for Sailfish OS.
https://openrepos.net/content/slava/barcode
13 stars 12 forks source link

Icon refresh and correction #14

Closed ApostolosB closed 4 years ago

ApostolosB commented 4 years ago

The icon used now doesn't follow the design "spec" by jolla. To be exact the icon has sharp edges instead of rounded that are used in the SFOS template icons. I corrected this and polished the original a bit. A pretty similar icon over all.

monich commented 4 years ago

Good point about the corners.

monich commented 4 years ago

Shoudln't the QR code shadow be moved horizontally (e. g. to the left) by the same amount as it's moved down, to give it even more 3-D kind of look? Not that it would be really noticeable at a typical resolution. I'm not quite sure, what do you think?

ApostolosB commented 4 years ago

The gradient of the background colour is vertical and the shadow follows the same light pattern. I didn't want it to look too 3D when i was designing it. Hence the minimal shadow. I like it this way TBH.

monich commented 4 years ago

Ok, so be it!

monich commented 4 years ago

I squashed these commits into one, so you will have to rebase your master branch, I think.

monich commented 4 years ago

Thanks!