search

monika-soam / Pokemon-world

0 stars 1 forks source link

Setup Kanban-Board #22

Open monika-soam opened 2 years ago

monika-soam commented 2 years ago

For the reviewer

We are a team of 2 people

Below is the link to our project

https://github.com/monika-soam/kanban-board/projects/1

Meltrust commented 2 years ago

Hi team,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

You can do it

Required Changes ♻️

As requested by the previous reviewer:

image

Explanation

All cards with group tasks in the title should be assigned to someone.

Note: If you still don't understand the requirement, please contact me on Slack.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

monika-soam commented 2 years ago

It's fixed now, I am so sorry for this silly mistake.

Mihndim2020 commented 2 years ago

STATUS: APPROVED!!! 🎉 🎉 🎉 :champagne: :champagne: :champagne:

Hi Team,

Your project is complete! Great work on making the changes requested by the previous reviewer. There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉 🎉 🎉 :champagne: :champagne: :champagne:

Congratulations-Memes-FEATURED

Optional suggestions

Check the comments under the review.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.