NPE when groupName in Roster is empty

[GoogleCodeExporter]

See the roster below with empty names like <group></group>. The "Add to a
group" action permits empty groupName.

LOAD ROSTER
Procesing groupName: null
08:39:49.379 [ERROR] [HablarHtml] Uncaught exception escaped
java.lang.NullPointerException: null
    at
com.calclab.hablar.roster.client.groups.RosterGroupPresenter.isAllContacts(Roste
rGroupPresenter.java:90)
    at
com.calclab.hablar.roster.client.groups.RosterGroupPresenter.<init>(RosterGroupP
resenter.java:28)
    at
com.calclab.hablar.roster.client.page.RosterPresenter.createGroup(RosterPresente
r.java:145)
    at
com.calclab.hablar.roster.client.page.RosterPresenter.loadRoster(RosterPresenter
.java:158)
    at
com.calclab.hablar.roster.client.page.RosterPresenter.access$0(RosterPresenter.j
ava:150)
    at
com.calclab.hablar.roster.client.page.RosterPresenter$2.onEvent(RosterPresenter.
java:90)
    at
com.calclab.hablar.roster.client.page.RosterPresenter$2.onEvent(RosterPresenter.
java:1)
    at com.calclab.suco.client.events.Event.fire(Event.java:77)
    at com.calclab.suco.client.events.Event.fire(Event.java:51)
    at
com.calclab.emite.im.client.roster.AbstractRoster.fireRosterReady(AbstractRoster
.java:113)
    at
com.calclab.emite.im.client.roster.RosterImpl$6.onEvent(RosterImpl.java:186)
    at
com.calclab.emite.im.client.roster.RosterImpl$6.onEvent(RosterImpl.java:1)
    at
com.calclab.emite.core.client.xmpp.session.IQManager.handle(IQManager.java:48)
    at
com.calclab.emite.core.client.xmpp.session.SessionImpl$1.onEvent(SessionImpl.jav
a:68)
    at
com.calclab.emite.core.client.xmpp.session.SessionImpl$1.onEvent(SessionImpl.jav
a:1)
    at com.calclab.suco.client.events.Event.fire(Event.java:77)
    at com.calclab.suco.client.events.Event.fire(Event.java:51)
    at
com.calclab.emite.core.client.bosh.AbstractConnection.fireStanzaReceived(Abstrac
tConnection.java:85)
    at
com.calclab.emite.core.client.bosh.BoshConnection.handleResponse(BoshConnection.
java:201)
    at
com.calclab.emite.core.client.bosh.BoshConnection.access$3(BoshConnection.java:1
89)
    at
com.calclab.emite.core.client.bosh.BoshConnection$1.onResponseReceived(BoshConne
ction.java:71)
    at
com.calclab.emite.core.client.services.gwt.GWTConnector$1.onResponseReceived(GWT
Connector.java:47)
    at
com.google.gwt.http.client.Request.fireOnResponseReceived(Request.java:287)
    at
com.google.gwt.http.client.RequestBuilder$1.onReadyStateChange(RequestBuilder.ja
va:393)
    at sun.reflect.GeneratedMethodAccessor77.invoke(Unknown Source)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav
a:43)
    at java.lang.reflect.Method.invoke(Method.java:616)
    at com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
    at com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
    at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:157
)
    at
com.google.gwt.dev.shell.BrowserChannel.reactToMessagesWhileWaitingForReturn(Bro
wserChannel.java:1713)
    at
com.google.gwt.dev.shell.BrowserChannelServer.invokeJavascript(BrowserChannelSer
ver.java:165)
    at
com.google.gwt.dev.shell.ModuleSpaceOOPHM.doInvoke(ModuleSpaceOOPHM.java:120)
    at com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:507)
    at
com.google.gwt.dev.shell.ModuleSpace.invokeNativeObject(ModuleSpace.java:264)
    at
com.google.gwt.dev.shell.JavaScriptHost.invokeNativeObject(JavaScriptHost.java:9
1)
    at com.google.gwt.core.client.impl.Impl.apply(Impl.java)
    at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:188)
    at sun.reflect.GeneratedMethodAccessor75.invoke(Unknown Source)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav
a:43)
    at java.lang.reflect.Method.invoke(Method.java:616)
    at com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
    at com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
    at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:157
)
    at
com.google.gwt.dev.shell.BrowserChannel.reactToMessages(BrowserChannel.java:1668
)
    at
com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelSe
rver.java:401)
    at
com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:222)
    at java.lang.Thread.run(Thread.java:636)

The roster:

<iq type="result" id="roster_2" to="admin@localhost/Gajim">
<query xmlns="jabber:iq:roster">
<item jid="vjrj@localhost" name="vjrj" subscription="both">
<group>Top Level</group>
</item>
<item jid="luther@localhost" name="luther" subscription="from">
<group>
</group>
</item>
<item jid="bertrand@localhost" name="bertrand" subscription="to">
<group>
</group>
</item>
<item jid="test1@localhost" name="test1" subscription="both"/>
<item jid="test2@localhost" name="test2" subscription="both"/>
<item jid="fafafa@localhost" name="fafafa" subscription="both">
<group>
</group>
</item>
</query>
</iq>

Original issue reported on code.google.com by vruiz.ju...@gmail.com on 17 Feb 2010 at 7:51

[GoogleCodeExporter]

Original comment by danigb on 17 Feb 2010 at 12:19

• Changed state: Fixed
• Added labels: Component-Hablar, Milestone-Surevine-Iter3, Surevine

[GoogleCodeExporter]

This issue was closed by revision r1258.

Original comment by danigb on 17 Feb 2010 at 12:23