search

monim67 / django-bootstrap-datepicker-plus

Bootstrap3/Bootstrap4/Bootstrap5 DatePickerInput, TimePickerInput, DateTimePickerInput, MonthPickerInput, YearPickerInput with date-range-picker functionality for django >= 2.0
https://pypi.python.org/pypi/django-bootstrap-datepicker-plus
MIT License
223 stars 61 forks source link

Replaced obsolete ifequal/ifnotequal expressions #58

Closed claudep closed 3 years ago

claudep commented 3 years ago

The ifequal/ifnotequal template expressions are obsolete and removed in Django main branch.

monim67 commented 3 years ago

What if we use {% include "django/forms/widgets/attrs.html" %} instead as django/forms/widgets/input.html does and let django handle the attributes? Let me know what you think and update the PR if needed.

claudep commented 3 years ago

Well spotted! I updated the PR with your suggestion.

claudep commented 3 years ago

@monim67, what happened to this patch/commit? It looks like the master branch regressed a lot after latest merges. Did you force push on master?

monim67 commented 3 years ago

I have merged huge changes to the master as part of new release plan. I force pushed the merge commit few times to get the github action working.

claudep commented 3 years ago

Force pushing on master is unfortunately a big mistake, as you broke all clones of your repository (while force pushing on work branches is fine). You also overwrote some commits like this one. May I ask you to re-apply the changes from this PR?

monim67 commented 3 years ago

I accidentally dropped the commit during a rebase!!! I have included it again, thanks for notifying it :+1:

claudep commented 3 years ago

Thanks, but note that you should absolutely avoid rebases on the master branch.