add postgresql support for zabbix 3.0

monitoringartist / dockbix-xxl

:whale: Dockerized Zabbix - server, web, proxy, java gateway, snmpd with additional extensions

https://hub.docker.com/u/monitoringartist/

GNU General Public License v2.0

377 stars 136 forks source link

add postgresql support for zabbix 3.0 #25

Closed itatabitovski closed 7 years ago

itatabitovski commented 8 years ago

Could you please add postgresql support to zabbix 3.0?

jangaraj commented 8 years ago

Yes. It's in my TODO, but unfortunately my time is limited. Will be awesome if you can create PR. You will need to:

add postgresql libs + compile everything again => 2 zabix_server binaries will be in the docker image and then some environment variable (eg ZS_DBEngine default = mysql) will start the zabbix server with selected DB support
update bootstrap.sh, so postgresql SQL willl be imported automatically Probably zabbix-db-postresql image will be useful as well (I have seen some in Github).

itatabitovski commented 8 years ago

@jangaraj why would you need 2 zabbix_server binaries? isn't it just adding --with-psql in the configure enough?

jangaraj commented 8 years ago

I really don't want to manage many Docker images. I would like to have only one common image and then user will specify, what should be executed in the container. Zenoss is also following this concept - they have many "monitoring microservices" in one Docker image. I know it's not really proper microservice Docker concept, but unfortunately Zabbix is not designated to be microservice. If I create psql version for server, then also web/proxy/agent should have their psql Dockerfile version -> I don't want to manage for example 10 Zabbix Docker images atm.

BTW: you still can't compile --with-mysql --with-postgresql: configure: error: You can configure for only one database. - I was trying it also in 2.4 ages ago.

luchnck commented 7 years ago

Postgresql support added in my fork, luchnck/zabbix-xxl-postgresql. I tried to follow Your recommendations in part of "zabbix_server binary for each type db in one image" for multibase support (depends on $DB_engine env variable), now is available basic usage with external pgsql db (such as start container with link on external DB, init zbx server/proxy database if not exist), there is no specialized image for postgresql db, but I built and tested it with hasufell/gentoo-postgresql image,if its ok, i think that'll needs to optimize it for zbx needs in future.

jangaraj commented 7 years ago

@luchnck 👍 I'm watching your repo. Do you want to keep that postgresql fork in your repo?

luchnck commented 7 years ago

Yes, but if it can be usable for project, we can merge it

jangaraj commented 7 years ago

Unfortunately, PostgreSQL version is not an easy task, due to direct SQL support. Link to https://github.com/luchnck/zabbix-xxl-postgresql has been added into README.