search

monitorjbl / excel-streaming-reader

An easy-to-use implementation of a streaming Excel reader using Apache POI
Apache License 2.0
953 stars 344 forks source link

Fixed StreamingRow.getLastCellNum() #61

Closed ToddWarwaruk closed 7 years ago

ToddWarwaruk commented 8 years ago

The previous implementation of StreamingRow.getLastCellNum() was returning the number of physical cells + 1, it was not returning the index + 1 of the last cell. I also implemented StreamingRow.getPhysicalNumberOfCells()

monitorjbl commented 7 years ago

Sorry for taking so long to get around to reviewing this, looks good to me!

ToddWarwaruk commented 7 years ago

Thanks!

Todd Warwaruk Platform Architect Trax Technologies, Inc. M: 480-206-5458 TraxTech.Com http://traxtech.com/ https://www.linkedin.com/company/trax-technologies https://twitter.com/TraxTech https://plus.google.com/+TraxTechnologiesScottsdale https://www.youtube.com/channel/UC3dLvg5LNV9ot6pgdQluw5g

On Fri, Nov 25, 2016 at 8:55 AM, Taylor Jones notifications@github.com wrote:

Sorry for taking so long to get around to reviewing this, looks good to me!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/monitorjbl/excel-streaming-reader/pull/61#issuecomment-262985450, or mute the thread https://github.com/notifications/unsubscribe-auth/AHLXa73PpZctNZKmPmWnrMfWk8khtRPNks5rBwUIgaJpZM4Ko4Hj .

-- CONFIDENTIALITY NOTICE: The preceding and/or attached information may be confidential or privileged. It should be used or disseminated solely for the purpose of conducting business with Trax. If you are not an intended recipient, please notify the sender by replying to this message and then delete the information from your system. Thank you for your cooperation.