monitorjbl / pr-harmony

Extra pull request workflows for Stash
GNU General Public License v3.0
33 stars 17 forks source link

Add all members that have access to the project as default reviewers #44

Open ghost opened 8 years ago

ghost commented 8 years ago

We have some projects where all the team members review code. Once in a while some new members join these projects, some of them leave.

It would be great to improve default reviewers functionality that all project members would be automatically added as default reviewers and there would not be necessary to update default reviewers manually. It could be separate options for adding all project members as reviewers or members with write/read or members with read only permissions.

monitorjbl commented 8 years ago

I'm not sure if that's a particularly useful feature in the general case. Bitbucket has a user group system that would let you do this right now, just put all your temporary users in one group and add it to the default reviewer list. You can grant them access to the project with the same group, too.

ghost commented 8 years ago

In our case we have 18 projects with different user set. The problem is that Project Managers have permission to add/remove developers from the project (Bitbucket Project Creator permission), but they do not have access to modify groups (which needs Admin permission). Code reviewers who review code for all of the projects are assigned to separate Bitbucket group and it is selected as default PR Harmony reviewers group. It works great! Rest of the developers who migrate between projects are assigned in project's settings "Repository permissions" tab. It would be convenient If all these developers who are assigned to the project could be included into default reviewers list without creating additional groups and giving admin rights to the Project Managers.