search

monitorjbl / pr-harmony

Extra pull request workflows for Stash
GNU General Public License v3.0
33 stars 17 forks source link

PR Harmony 2.3.1 compatibility with Bitbucket 4.3.2 #46

Open AkulBhatnagar opened 8 years ago

AkulBhatnagar commented 8 years ago

I am using Bitbucket 4.3.2 and installed PR Harmony 2.3.1. But when I tried to configure PR Harmony for one of the Repo and click on Save button. I found that it saved nothing. And even when I created PR, there was nothing (no default reviewer, no required approver etc.)

Whereas there is an exception for local bitbucket users. It seemed to work for local users.

monitorjbl commented 8 years ago

I've tested with that Bitbucket version (and just retested for sanity) without issue, so I don't think this is a compatibility problem. Can you share your browser version, the URL of your Bitbucket server, and the output of your browser console when you try to save the page? I suspect that there's an environment issue here.

AkulBhatnagar commented 8 years ago

My browser is google chrome and version is Version 50.0.2661.102 m http://t-xxx-us-stash3:7990/

Please note I used PR Harmony version 2.2.0 for this test since I had the same issue with the latest version as well. If you want I can use the latest version. Console Output is as follows:

DEPRECATED JS - Cookie has been deprecated since 5.8.0 and will be removed in a future release. Use cookie instead.
at b.default (http://t-xxx-us-stash3:7990/s/9ef78f5663816f7f756c6bda5af6d5d6-CDN/en_US/cd…38be29268c2/_/download/contextbatch/js/_super/batch.js?locale=en-US:54:349) batch.js?locale=en-US:353 DEPRECATED - requiring 'eve' has been deprecated since AUI 5.7 and will be removed in AUI 6.0. batch.js?locale=en-US:57 DEPRECATED JS - Inline dialog constructor has been deprecated and will be removed in a future release. Use inline dialog 2 instead.
at b.init (http://t-xxx-us-stash3:7990/s/5d18d062121ec77903e4022d9197eee2-T/en_US/cd2e…&nps-enabled=true&nps-not-opted-out=true&supportedApplication=true:410:219) batch.js?locale=en-US:57 DEPRECATED JS - Inline dialog constructor has been deprecated and will be removed in a future release. Use inline dialog 2 instead.
at Object.t.onReady (http://t-xxx-us-stash3:7990/s/5d18d062121ec77903e4022d9197eee2-T/en_US/cd2e…ps-enabled=true&nps-not-opted-out=true&supportedApplication=true:1143:2997) batch.js?locale=en-US:242 [PR Harmony]: Using environment: Object {baseUrl: "http://t-xxx-us-stash3:7990", projectKey: "SAND", repoSlug: "global-playground"} batch.js?locale=en-US:242 [PR Harmony]: Loading configuration batch.js?locale=en-US:242 [PR Harmony]: Configuration loaded Object {defaultReviewers: Array[0], defaultReviewerGroups: Array[0], requiredReviewers: Array[1], requiredReviewerGroups: Array[0], requiredReviews: 1…} bridge.js:1 Connecting to PORT_NAME_SYMANTEC_PKI_CLIENT_CONTENT_TO_BACKGROUND... bridge.js:1 Connected: Port {} bridge.js:1 Done. detection.js:1 +content/detection.js detection.js:1 -content/detection.js

AkulBhatnagar commented 8 years ago

Any findings, please share.

monitorjbl commented 8 years ago

It doesn't look like anything stands out in your environment. However, if your username has a capital letter in it there was a bug fixed in PR Harmony 2.3.1 to allow correct saves. Might be worth trying out that version.

AkulBhatnagar commented 8 years ago

I tried with PR 2.3.1 as well. Getting similar issue.

andyliu38 commented 7 years ago

I'm using PR Harmony 2.3.1 with bitbucket server v4.10.1.

I notice in IE11, the default reviewer group are not added at p/r creation even though a default review group is set/saved. But this issue is fine in FireFox and Chrome. IE Compatibility setting seems like is not the culprit. My username is all cap.

Thought? Thanks.