When using the plugin with Bitbucket 5.1.1 and the following settings
Number of reviews = 1
Required users = Some users
we had the problem that a Approve by one of the users configured as 'Required users' wasn't sufficient to merge the PullRequest. Debugging showed that ApplicationUser#getSlug() returned the Username in lowercase but pr-harmony was reading them from the configuration using camel case. Converting the username to lowercase before validating fixed the problem...
Probably there are more places in the plugin code which have to be adjusted accordingly but this change was sufficient for our needs.
monitorjbl
commented
7 years ago
When using the plugin with Bitbucket 5.1.1 and the following settings
Number of reviews = 1 Required users = Some users
we had the problem that a Approve by one of the users configured as 'Required users' wasn't sufficient to merge the PullRequest. Debugging showed that ApplicationUser#getSlug() returned the Username in lowercase but pr-harmony was reading them from the configuration using camel case. Converting the username to lowercase before validating fixed the problem...
Probably there are more places in the plugin code which have to be adjusted accordingly but this change was sufficient for our needs.