Closed SethTisue closed 5 years ago
https://github.com/monix/minitest/pull/19
[minitest] [error] 'by-name-right-associative' is not a valid choice for '-Xlint'
[minitest] [error] 'unsound-match' is not a valid choice for '-Xlint'
after #19 was merged, I tried the Scala 2.13 community build and got:
[minitest] [error] /Users/tisue/community.213/target-0.9.12/project-builds/minitest-140990deb8a820140508cf1c8a3f44a72fc477aa/shared/src/main/scala/minitest/runner/Framework.scala:30:5: trait Runner is abstract; cannot be instantiated
[minitest] [error] new Runner(args, remoteArgs, testClassLoader)
[minitest] [error] ^
[minitest] [info] No documentation generated with unsuccessful compiler run
[minitest] [error] one error found
[minitest] [error] /Users/tisue/community.213/target-0.9.12/project-builds/minitest-140990deb8a820140508cf1c8a3f44a72fc477aa/shared/src/main/scala/minitest/runner/Framework.scala:30:5: trait Runner is abstract; cannot be instantiated
[minitest] [error] new Runner(args, remoteArgs, testClassLoader)
[minitest] [error] ^
this looks a consequence of https://github.com/scala/scala/pull/6589; import sbt.testing.{Framework => BaseFramework, _}
is importing Runner
and then (after PR 6589) that shadows minitest.runner.Runner
note that 6589 was merged post-M4, so you won't actually hit this when publishing for M4
if I run the community build now with version=2.13.0-M4
I get:
[info] Project minitest--------------------: SUCCESS (project rebuilt ok)
so that's promising.
minitest remains green in the 2.13 community build. I've updated this ticket name now that Scala 2.13.0-M5 is out
scalacheck needs to publish first, I think. https://github.com/rickynils/scalacheck/issues/418
ScalaCheck 1.14.0 is now published for M5 (both JVM & JS), so this should be unblocked now, I think?
@alexandru anything you could use community help with, here?
@SethTisue Can you review #30?
@ashawley done (I ✅'ed)
ticket is closed, but I don't see artifacts at https://repo1.maven.org/maven2/io/monix/minitest_2.13.0-M5 ?
@SethTisue I don’t remember closing it, however I’ll publish it tomorrow.
@SethTisue I published it with version 2.2.2
awesome! scala/make-release-notes@32059eae9dff65418eb9b8f2fa6fba72a975a66c
Sorry for additional noise (spamming), I should have known better :worried:
I think your dependencies are available for M4 now? (not 100% sure)
in the Scala 2.13 community build, at e.g. https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/1228/consoleFull, I'm seeing that getting minitest onto the new collections would also help unlock a bunch of downstream projects. (most of which need cats too, but cats isn't too far from being able to publish, too.)