search

monix / monix-connect

A set of connectors for Monix. 🔛
https://connect.monix.io
Apache License 2.0
59 stars 17 forks source link

monix-redis 0.6.0-RC-1 dependent on scalapb #652

Open VladKopanev opened 3 years ago

VladKopanev commented 3 years ago

We are trying to use monix-redis version 0.6.0-RC-1 in our project, but at the same time, our project is dependent on scalapb-runtime version 0.9.4 which is binary incompatible with scalapb-runtime version 0.10.1 which is brought by monix-redis dependency, hence errors in runtime. I think monix-redis should exclude any scalapb dependency because why have them?

paualarco commented 3 years ago

Thanks for reporting this. You are right, ScalaPB dependency should not be included in the monix-redis artifact. The dependency is just used in tests so we need to avoid that. For the time being, I think you could either force using 0.9.4 in your project or excluding the one that comes along with monix?

VladKopanev commented 3 years ago

Yeah, no problems, I just added excludeAll(ExclusionRule(organization = "com.thesamet.scalapb") to my monix-redis dependency and it works fine.

paualarco commented 3 years ago

Great!