Task.parSequence => Task.gather

wibisono commented 4 years ago

Task.gather compiles when I tested with ammonite using monix 3.2.2.

Though I am not sure if the docs that needs to be updated, or the code that should be using parSequence.

netlify[bot] commented 4 years ago

Deploy request for monix-io accepted.

Accepted with commit 2088b833d5a54c68d65b497ff5f4381669b3c25f

https://app.netlify.com/sites/monix-io/deploys/5f2013f796e30500087655c9

Avasil commented 4 years ago

We deprecated it in favor of parSequence, we won't fully remove it until at least 4.x

alexandru commented 4 years ago

The build emits warnings about the deprecation too:

warning: /home/runner/work/monix.io/monix.io/_docs/3x/tutorials/parallelism.md:50:17: method gather in class Companion is deprecated (since 3.2.0): Use parSequence
val aggregate = Task.gather(tasks).map(_.toList)
                ^^^^^^^^^^^
warning: /home/runner/work/monix.io/monix.io/_docs/3x/tutorials/parallelism.md:77:45: method gather in class Companion is deprecated (since 3.2.0): Use parSequence
val batches = tasks.sliding(10,10).map(b => Task.gather(b)).toIterable
                                            ^^^^^^^^^^^
warning: /home/runner/work/monix.io/monix.io/_docs/3x/tutorials/parallelism.md:111:47: method gather in class Companion is deprecated (since 3.2.0): Use parSequence
  val batches = tasks.sliding(10,10).map(b => Task.gather(b)).toIterable

I wonder if we could enable -Xfatal-warnings with mdoc 🤔

alexandru commented 4 years ago

@wibisono Task.gather is deprecated, being renamed to parSequence, as @Avasil mentioned.

This happened for naming consistency with Cats / Cats-Effect, and because it is a clearer name for what it does. Task.gather comes from the old Task Scalaz 7.x, but nobody uses that anymore.

alexandru commented 4 years ago

Will close this for now. Feel free to keep suggesting improvements to these docs ❤️

monix / monix.io

Task.parSequence => Task.gather #105